misc: align deferred intent UPE checkout script with previous UPE versions #7528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
changed the title
timur27
force-pushed
the
misc/checkout-scipt-alignment
branch
from
45653e2 to
6f956d3
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +133 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
timur27
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The deferred intent creation UPE checkout script doesn't apply font rules from page to the Stripe Payment Element, while it does so in previous legacy UPE and split UPE checkouts. This PR aligns with this setting.
On top of it, we now stop loading the script if there's no
publishableKeyjust as a measure to prevent the script from loading on the wrong page. I couldn't find a way to test it because if we're on non-checkout page, the script is simply not enqueued. This is also just a tiny alignment of dUPE to follow split UPE/legacy UPE/non-UPE approach.Testing instructions
To test fonts, start by checking out
develop, building the code.DelithemeAt this point, checkout
misc/checkout-scipt-alignmentandAlthough, like I mentioned earlier, I have no use-case to test the script loading prevention after the
publishableKeycheck, this change is the alignment with split UPE, legacy UPE & legacy card. The only thing as part of testing, perform a test purchase on the shortcode page and e.g., add payment method page and confirm that everything works as expected.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge