Unify payment method icon design #7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still need to fix some failing tests, mostly just recreating snapshots. Also, this PR needs to address the use cases where assets are used as CSS backgrounds. I might skip it since there are no problems with alignment or borders. |
kalessil
reviewed
Oct 26, 2023
mgascam
reviewed
Oct 26, 2023
client/payment-methods-map.tsx
Outdated
| @@ -200,11 +197,10 @@ const PaymentMethodInformationObject: Record< | |||
| affirm: __( 'Affirm', 'woocommerce-payments' ), | |||
| }, | |||
| description: __( | |||
| // translators: %s is the store currency. | |||
| 'Allow customers to pay over time with Affirm. Available to all customers paying in %s.', | |||
| 'Expand your business with Affirm', | |||
There was a problem hiding this comment.
I noticed we are changing the description for Affirm and Afterpay, is this intended? Asking because for Klarna we are not changing this description.
There was a problem hiding this comment.
Not intended, thanks for pointing out. Could be incorrect merge from develop. I'll look into that.
kalessil
reviewed
Oct 26, 2023
|
@mgascam Thank you for pointing out the missing LinkIcon. I've implemented all requested changes. Just need to resolve failing tests (in most cases recreating snapshot) |
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +4.83 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
dmvrtx
approved these changes
Oct 27, 2023
Some use cases like removing PM modal relies on additional classes added to the root img
Current grid component is not resiable and brakes the design for enabling Credit card modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7183
Changes proposed in this Pull Request
Unify the design for Payment method and Card icon design.
Testing instructions
TODO: Need to list all use places. Quite hard to gather them all
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge