Display express payment buttons on checkout blocks pay-for-order page #7570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
requested review from
a team and
malithsen
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
malithsen
approved these changes
Oct 27, 2023
| if ( $this->is_pay_for_order_page() ) { | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: I feel like it would be more appropriate to update the logic in line 541 to exclude pay-for-orders instead of a top-level return true. Excluding the pay-for-order page in line 541 would make it easier to reason out the logic.
It will also match the existing pattern of this function, where we bail out if conditions are met and only return true at the very end.
That said, I don't have any strong objections to the current implementation.
Suggested change for line 541 instead of above:
( ! $this->is_product() && ! $this->is_pay_for_order_page() && 0.0 === (float) WC()->cart->get_total( 'edit' ) ) ||
There was a problem hiding this comment.
Good idea! Updated here ab2c28f.
hsingyuc
deleted the
fix/express-payment-buttons-on-blocks-pay-for-order-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
When the page has blocks we don't initialize the express payment buttons, so if it's a pay-for-order page but the checkout page uses blocks, we won't see the express payment buttons even though pay-for-order never shows the checkout blocks. This PR adds the logic to display the buttons on pay-for-order pages when the checkout page is using checkout blocks.
Design discussion in this PR.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge