Avoid returning Stripe error message when capturing more than order amount #7581

mgascam · 2023-10-30T17:06:42Z

Fixes #7029

Changes proposed in this Pull Request

Redact the prompt in order notes to contact Stripe support when a merchant attempts to capture more than the authorized amount. Contacting support is unnecessary in this case.
Introduce Amount_Too_Large_Exception API exception

Before

261541727-6f87fd67-9afa-462b-a7fa-1a693c0b2339

After

Testing instructions

As a merchant, enable the authorize and capture later setting under Payments > Settings.
As a shopper, place an order
As a merchant, edit the order to add a fee or use any other method to increase the order total beyond its original amount.
Using order actions box, try to capture the order.
Ensure there's no prompt advising the merchant to contact Stripe support (refer to the "After" screenshot above).

Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Post merge

Link to testing instructions from release testing doc following these instructions : Add link here / 'QA Testing Not Applicable'
Add or update critical flows and testing instructions for critical flows, if applicable.
Add what's changed (description, screenshot, demo videos etc.) to the release announcement post, if applicable.

botwoo · 2023-10-30T17:13:34Z

Test the build

Option 1. Jetpack Beta

Install and activate Jetpack Beta.
Use this build by searching for PR number 7581 or branch name update/7029-avoid-returning-stripe-error-message-when-capturing-more-than-order-amount in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

Latest commit: f5662c7
Build time: 2023-11-02 15:44:19 UTC

Note: the build is updated when a new commit is pushed to this PR.

github-actions · 2023-10-30T17:15:36Z

Size Change: 0 B

Total Size: 1.44 MB

ℹ️ View Unchanged

Filename	Size
`release/woocommerce-payments/assets/css/admin.css`	1.06 kB
`release/woocommerce-payments/assets/css/success.css`	158 B
`release/woocommerce-payments/dist/blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/blocks-checkout.js`	75.1 kB
`release/woocommerce-payments/dist/checkout-rtl.css`	441 B
`release/woocommerce-payments/dist/checkout.css`	442 B
`release/woocommerce-payments/dist/checkout.js`	28.9 kB
`release/woocommerce-payments/dist/index-rtl.css`	36.4 kB
`release/woocommerce-payments/dist/index.css`	36.4 kB
`release/woocommerce-payments/dist/index.js`	285 kB
`release/woocommerce-payments/dist/multi-currency-analytics.js`	1.05 kB
`release/woocommerce-payments/dist/multi-currency-rtl.css`	3.39 kB
`release/woocommerce-payments/dist/multi-currency-switcher-block.js`	60.2 kB
`release/woocommerce-payments/dist/multi-currency.css`	3.39 kB
`release/woocommerce-payments/dist/multi-currency.js`	55.4 kB
`release/woocommerce-payments/dist/order-rtl.css`	676 B
`release/woocommerce-payments/dist/order.css`	679 B
`release/woocommerce-payments/dist/order.js`	41.4 kB
`release/woocommerce-payments/dist/payment-gateways-rtl.css`	1.3 kB
`release/woocommerce-payments/dist/payment-gateways.css`	1.3 kB
`release/woocommerce-payments/dist/payment-gateways.js`	39 kB
`release/woocommerce-payments/dist/payment-request-rtl.css`	153 B
`release/woocommerce-payments/dist/payment-request.css`	153 B
`release/woocommerce-payments/dist/payment-request.js`	13.1 kB
`release/woocommerce-payments/dist/product-details.js`	898 B
`release/woocommerce-payments/dist/settings-rtl.css`	9.99 kB
`release/woocommerce-payments/dist/settings.css`	10 kB
`release/woocommerce-payments/dist/settings.js`	232 kB
`release/woocommerce-payments/dist/subscription-edit-page.js`	669 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.js`	20.4 kB
`release/woocommerce-payments/dist/subscription-product-onboarding-toast.js`	693 B
`release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.js`	19.5 kB
`release/woocommerce-payments/dist/tos-rtl.css`	230 B
`release/woocommerce-payments/dist/tos.css`	231 B
`release/woocommerce-payments/dist/tos.js`	21.9 kB
`release/woocommerce-payments/dist/upe_checkout-rtl.css`	441 B
`release/woocommerce-payments/dist/upe_checkout.css`	442 B
`release/woocommerce-payments/dist/upe_checkout.js`	34.1 kB
`release/woocommerce-payments/dist/upe_split_checkout-rtl.css`	441 B
`release/woocommerce-payments/dist/upe_split_checkout.css`	442 B
`release/woocommerce-payments/dist/upe_split_checkout.js`	34.7 kB
`release/woocommerce-payments/dist/upe_with_deferred_intent_creation_checkout.js`	37.1 kB
`release/woocommerce-payments/dist/upe-blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.js`	40.9 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.js`	42.5 kB
`release/woocommerce-payments/dist/woopay-express-button-rtl.css`	153 B
`release/woocommerce-payments/dist/woopay-express-button.css`	153 B
`release/woocommerce-payments/dist/woopay-express-button.js`	52 kB
`release/woocommerce-payments/dist/woopay-rtl.css`	3.91 kB
`release/woocommerce-payments/dist/woopay.css`	3.91 kB
`release/woocommerce-payments/dist/woopay.js`	71.7 kB
`release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css`	622 B
`release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js`	814 B
`release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js`	2.43 kB
`release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js`	1.01 kB
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js`	522 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js`	581 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js`	160 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css`	2.32 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js`	13.8 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css`	2.32 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css`	1.03 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css`	291 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css`	403 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css`	3.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css`	299 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css`	742 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css`	572 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css`	411 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js`	9.4 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js`	6.8 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js`	3.83 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js`	2.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js`	22.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js`	11.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js`	1.29 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js`	502 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js`	355 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js`	429 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js`	1.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js`	781 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js`	1.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js`	1.27 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css`	392 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js`	3.05 kB

_{compressed-size-action}

includes/class-wc-payment-gateway-wcpay.php

…nt too large error

…message-when-capturing-more-than-order-amount

kalessil

It looks better, we can now polish details and reliability aspects.

includes/wc-payment-api/class-wc-payments-api-client.php

…message-when-capturing-more-than-order-amount

includes/wc-payment-api/class-wc-payments-api-client.php

kalessil

LGTM (code review only)!

…message-when-capturing-more-than-order-amount

dmvrtx

Looks good to me code-wise.

…message-when-capturing-more-than-order-amount

…mount (#7581)

mgascam linked an issue Oct 30, 2023 that may be closed by this pull request

Avoid returning Stripe error message when capturing more than order amount #7029

Closed

kalessil requested changes Oct 31, 2023

View reviewed changes

includes/class-wc-payment-gateway-wcpay.php Outdated Show resolved Hide resolved

kalessil assigned mgascam Oct 31, 2023

kalessil added the pr: needs author reply label Oct 31, 2023

Omit contact Stripe support from the order notes when there's an amou…

5630836

…nt too large error

mgascam force-pushed the update/7029-avoid-returning-stripe-error-message-when-capturing-more-than-order-amount branch from 66c4060 to 5630836 Compare October 31, 2023 16:10

Introduce Amount_Too_Large_Exception

d8bbe34

mgascam force-pushed the update/7029-avoid-returning-stripe-error-message-when-capturing-more-than-order-amount branch from 5da9b03 to d8bbe34 Compare October 31, 2023 17:28

Merge branch 'develop' into update/7029-avoid-returning-stripe-error-…

3c5ab5c

…message-when-capturing-more-than-order-amount

kalessil requested changes Nov 2, 2023

View reviewed changes

includes/wc-payment-api/class-wc-payments-api-client.php Show resolved Hide resolved

includes/wc-payment-api/class-wc-payments-api-client.php Outdated Show resolved Hide resolved

PR feedback: harden conditions to throw Amount_Too_Large_Exception

6f9a3c4

mgascam force-pushed the update/7029-avoid-returning-stripe-error-message-when-capturing-more-than-order-amount branch from e71a82b to 6f9a3c4 Compare November 2, 2023 08:49

mgascam changed the title ~~WIP: override amount_too_large Stripe error~~ Avoid returning Stripe error message when capturing more than order amount Nov 2, 2023

mgascam added 2 commits November 2, 2023 10:22

Add changelog

2258a83

Merge branch 'develop' into update/7029-avoid-returning-stripe-error-…

cb3670b

…message-when-capturing-more-than-order-amount

mgascam removed the pr: needs author reply label Nov 2, 2023

kalessil requested changes Nov 2, 2023

View reviewed changes

includes/wc-payment-api/class-wc-payments-api-client.php Outdated Show resolved Hide resolved

includes/wc-payment-api/class-wc-payments-api-client.php Outdated Show resolved Hide resolved

includes/wc-payment-api/class-wc-payments-api-client.php Outdated Show resolved Hide resolved

kalessil added the pr: needs author reply label Nov 2, 2023

kalessil marked this pull request as ready for review November 2, 2023 09:44

kalessil requested a review from a team November 2, 2023 09:44

Remove unnecessary isset check

6b36ddf

kalessil reviewed Nov 2, 2023

View reviewed changes

includes/wc-payment-api/class-wc-payments-api-client.php Outdated Show resolved Hide resolved

mgascam added 2 commits November 2, 2023 10:51

PR feedback: remove redundant comment

3d4250a

PR feedback: use Intent_Status constant

f8ad535

mgascam added pr: needs review and removed pr: needs author reply labels Nov 2, 2023

mgascam requested a review from a team November 2, 2023 10:07

kalessil approved these changes Nov 2, 2023

View reviewed changes

kalessil requested a review from a team November 2, 2023 10:37

Merge branch 'develop' into update/7029-avoid-returning-stripe-error-…

a2b09f8

…message-when-capturing-more-than-order-amount

dmvrtx approved these changes Nov 2, 2023

View reviewed changes

dmvrtx added pr: ready to merge and removed pr: needs review labels Nov 2, 2023

Merge branch 'develop' into update/7029-avoid-returning-stripe-error-…

f5662c7

…message-when-capturing-more-than-order-amount

mgascam enabled auto-merge November 2, 2023 15:39

mgascam added this pull request to the merge queue Nov 2, 2023

Merged via the queue into develop with commit 882b385 Nov 2, 2023
28 checks passed

mgascam deleted the update/7029-avoid-returning-stripe-error-message-when-capturing-more-than-order-amount branch November 2, 2023 15:59

james-allan pushed a commit that referenced this pull request Nov 6, 2023

Avoid returning Stripe error message when capturing more than order a…

84ecdd5

…mount (#7581)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid returning Stripe error message when capturing more than order amount #7581

Avoid returning Stripe error message when capturing more than order amount #7581

mgascam commented Oct 30, 2023 •

edited

Loading

botwoo commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

kalessil left a comment •

edited

Loading

kalessil left a comment

dmvrtx left a comment

Avoid returning Stripe error message when capturing more than order amount #7581

Avoid returning Stripe error message when capturing more than order amount #7581

Conversation

mgascam commented Oct 30, 2023 • edited Loading

Changes proposed in this Pull Request

Testing instructions

botwoo commented Oct 30, 2023 • edited Loading

Test the build

Option 1. Jetpack Beta

Option 2. Jurassic Ninja - available for logged-in A12s

github-actions bot commented Oct 30, 2023 • edited Loading

kalessil left a comment • edited Loading

Choose a reason for hiding this comment

kalessil left a comment

Choose a reason for hiding this comment

dmvrtx left a comment

Choose a reason for hiding this comment

mgascam commented Oct 30, 2023 •

edited

Loading

botwoo commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

kalessil left a comment •

edited

Loading