Get WooPay 1st party auth flow to work on page load #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.02 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
lovo-h
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Code changes look good and test well 👍
I left a comment regarding the WooPay button behavior when the request to WooPay fails. For better UX, I strongly recommend that we immediately switch over to the OTP flow, as opposed to displaying an error message and requiring the user to click the WooPay button once again. This is not a blocker so I'll go ahead and approve.
Testing instructions
- ✅ Test 1st party authentication works on page load for the Product, Cart, and Checkout page.
- ✅ Test 1st party authentication works a few seconds after the page loads for the Product, Cart, and Checkout page.
- ✅ Test 1st-party authentication failure for the Product, Cart, and Checkout page.
client/checkout/woopay/express-button/test/woopay-express-checkout-button.test.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woopay/issues/2210
Changes proposed in this Pull Request
At the moment, when the product page, cart or checkout page loads and a user clicks right away at the WooPay button, it triggers the OTP modal flow instead of the first party auth flow. That's happening because the first party auth flow depends on the iframe being loaded and that can take from some milliseconds to a couple of seconds.
This PR addresses that behavior and makes the first party auth the default flow from the moment the page loads. The only moment the OTP flow should be triggered is when the first party auth fails at any point before redirecting to WooPay checkout.
Testing instructions
Test 1st party authentication works on page load
2.1. Product page
2.2. Cart page
2.3. Checkout page
Test 1st party authentication works a few seconds after the page loads
2.1. Product page
2.2. Cart page
2.3. Checkout page
Test 1st party authentication failure
2.1. Product page
2.2. Cart page
2.3. Checkout page
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge