Exclude estimated deposits from useDeposits data hook by default #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +40 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
Jinksi
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
This tests well @haszari. Filtering out via the useDeposits data hook is a precise and succinct way to handle this before the server response change is deployed.
I've added a changelog entry and PR description with testing details – feel free to modify.
|
I've also updated the 
|
6 tasks
1 task
2 tasks
Jinksi
restored the
7604/no-estimated-deposits-on-deposits-detail-page
branch
Jinksi
deleted the
7604/no-estimated-deposits-on-deposits-detail-page
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7604
Changes proposed in this Pull Request
This PR filters out by
estimateddeposits from the Payments → Deposits screen by excluding theestimateddeposits from theuseDepositsdata hook by default.The
useDepositshook is only used by the DepositsList component (focus of this PR) and theuseRecentDepositshook, which explicitly filters outestimateddeposits anyway.Testing instructions
Estimateddeposits appear in the list.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge