chore: cleanup unused hook dependency #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +3 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
allie500
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Thanks for working on this, Francesco! The code changes are straightforward and make sense. All unit tests are passing for me. I tested the changes on a JN site. Before finishing the setup tasks, window.wcpaySettings.additionalMethodsSetup.isUpeEnabled returned false as expected. Once I completed the tasks, window.wcpaySettings.additionalMethodsSetup.isUpeEnabled returned true as expected.
I noticed some E2E tests failing on this PR but they don't seem related to the code changes here. I re-ran the three failed tests and they've all passed now. So I think we are good there as well.
I think this is ready to merge! 
|
Thanks so much for taking the time to review @allie500 ! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7603
Changes proposed in this Pull Request
Looks like there's a hook with some unused dependencies.
Was introduced here: ac8066b
Was edited here, without cleaning up the dependencies: bde5165
Fixing.
Testing instructions
Static analysis.
But you can also manually verify:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge