Calculate next deposit date rather than relying on estimated deposits #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +2 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
PHP tests are currently failing which is unrelated to this PR. |
@brucealdridge This looks like one PR that we had planned for 6.8 that can safely be merged. |
13 tasks
Jinksi
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
This tests well @brucealdridge and the code and tests written are clear and easy to follow. 🙌 I've also tested this in context within the new UI in PR https://github.com/Automattic/woocommerce-payments/pull/7656/files#diff-4c94aa3bacf97fd4b7e483719d334e36d72734af83e88b83cd1fc528e88347f9R29, so you can checkout that branch to see it in action.
Since this is not used by any existing logic, this is safe to merge for a 6.8 release.
I've left some code quality suggestions that (assuming you agree) we can resolve now or in a follow-up PR.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Jinksi
approved these changes
Nov 10, 2023
Co-authored-by: Eric Jinks <3147296+Jinksi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7628
Changes proposed in this Pull Request
Adds
getNextDepositDatefunction toclient/deposits/utils/index.ts. This function will be used as part of #7646This was originally considered as part of a server change. Due to complications with timezones, it made more sense to implement on the client as this is the only place we anticipate this logic being used.
When funds are dispatched and when they are received can vary and there are some very complex rules involved. One such rule is deposits are usually dispatched in UTC unless the account is created in the APAC region (docs)
Rather than trying to adapt the code to cover every possible situation, the changes in #7646 will use wording to convey that this is only an estimate.
... with your next scheduled deposit estimated for [date].Testing instructions
As this code is not used anywhere it is covered in unit tests.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge