-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WC Beta E2E tests - Add workaround to revert to classic checkout #7690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
achyuthajoy
added
category: e2e
Issues and PRs related to e2e tests.
category: devops
Features and tools supporting dev process.
pr: needs review
labels
Nov 10, 2023
deepakpathania
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving with a small comment, feel free to merge after addressing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: devops
Features and tools supporting dev process.
category: e2e
Issues and PRs related to e2e tests.
pr: ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7599
Changes proposed in this Pull Request
This PR adds a workaround for E2E test failures when using WC 8.3.0 or above since these versions uses blocks for checkout & cart pages. Though WC 8.3.0 or above uses block layout, it is possible to switch to classic layout by using the
[woocommerce_cart]
&[woocommerce_checkout]
shortcodes.This PR updates the setup script to check whether the installed version is >= WC 8.3.0 & if yes, modifies the cart & checkout page to use shortcodes via WP-CLI.
However, this is a temporary workaround since we have blocks tests for basic payment flows. A permanent solution would be to update the tests to use block checkout flows.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge