-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BNPL April announcement #8605
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +21 kB (+2%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Unassigning @FangedParakeet since he's been working on it as well :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good and works well for me. I've got a couple questions and then a few minor comments.
…woopayments orders
Updated modal appearance following design suggestions here -> pcUrMV-6V1-p2#comment-20981 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny note about the placement of an *
in the text, but other than that this looks good.
I'll approve, but leave up to you to move the *
or get a 2nd opinion and approval from design.
Co-authored-by: Brett Shumaker <brettshumaker@gmail.com>
Co-authored-by: Samir Merchant <samir.merchant@automattic.com> Co-authored-by: Brett Shumaker <brettshumaker@gmail.com>
} | ||
|
||
// Time boxed - Campaign expires after 90 days. | ||
if ( $this->current_time > strtotime( '2024-07-15 00:00:00' ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frosso, do you think it's time to delete these files? It's been more than ninety days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #8591
Changes proposed in this Pull Request
Adding a dialog to the admin area for merchants, to inform them that they can enable BNPL methods.
Testing instructions
US
)npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge