Increase font on WooPay button #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +149 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
|
Shortcode Cart Default Blocks Cart Default |
|
Shortcode Checkout Default - Before After Shortcode Checkout Med Shortcode Checkout Large Blocks Checkout Default - Before After Blocks Checkout Med Blocks Checkout Large |
|
Product Page - Before After Product Page Med Product Page Large |
LCmry
force-pushed
the
update/increase-woopay-button-font
branch
from
b0a41f6 to
ab17872
Compare
|
@pierorocca and @nikkivias for reviewing the look please. |
|
I'm on mobile and afk. At a quick glance the size looks good but the font weight seems heavier than the dev guidelines? Could you confirm the logic is getting applied to the light and outline theme options? |
|
Thanks for taking a look @pierorocca .
I only changed the font size. Where are the guidelines for weight? I can check into them. Can confirm it is the same for light and outline options. |
|
@LCmry what I'm seeing in the Figma is SF Pro Text Medium. Here's the Figma Large 54 px button for comparison. What web font is being used and current weight?
|
|
@pierorocca the current font is 'SF Pro Text' and current weight is 500. |
|
Thanks @LCmry. 500 does correspond to Medium. It looks like Figma rendering can be different than what's actually rendered by different devices and browsers. https://forum.figma.com/t/font-sfprotext-medium-displays-different-between-figma-vs-ios/9513 @nikkivias any thoughts here? Keep weight at 500 or drop down to 400 to try and match Figma? |
|
@nikkivias @pierorocca, I just wanted to follow up on this question:
|
|
@lovo-h I recommended making the code implementation look true to the Figma visual which I believe in this case requires ignoring the Figma sizing. |
|
@pierorocca @nikkivias, here are how the WooPay buttons look compared to the new ECE buttons. Before and After: Small (40 px) button size Before and After: Medium (48 px) button size Before and After: Large (55 px) button size The changes applied to the WooPay button in this PR are:
Given the scope of issue #8136, should we proceed as-is or should we consider making additional modifications? |
|
Looking better @lovo-h. For reference is that Chrome or Safari? I'd like to rule out differences between browsers. The weighting looks right to me compared to at 500. The font sizing however, we're smaller than the other buttons in the medium and large sized buttons? |
|
Note that depending on your platform and browser, and installed fonts, you might see variations between another person's experience. There's variability. To understand some of that variability, I've listed the font family for Stripe ECE, and WooPay. Safari on MacOS SonomaStripe ECE WooPay
|
This applies to both the medium and large WooPay buttons.
|
Thank you, @pierorocca. The font stack has been updated in 9b6986e. Here are the latest before and afters of how the WooPay buttons look compared to the ECE. Before and After: Small (40 px) button size
|
lovo-h
requested review from
a team and
cesarcosta99
and removed request for
a team
|
@nikkivias for final QA. |
bborman22
requested review from
a team,
lovo-h and
bborman22
and removed request for
cesarcosta99,
a team and
lovo-h
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Size Change: +162 B (0%)
Total Size: 1.33 MB
| Filename | Size | Change |
|---|---|---|
release/woocommerce-payments/dist/blocks-checkout-rtl.css |
2.16 kB | +81 B (+4%) |
release/woocommerce-payments/dist/blocks-checkout.css |
2.16 kB | +81 B (+4%) |
ℹ️ View Unchanged
| Filename | Size |
|---|---|
release/woocommerce-payments/assets/css/admin.css |
1.08 kB |
release/woocommerce-payments/assets/css/admin.rtl.css |
1.08 kB |
release/woocommerce-payments/assets/css/success.css |
173 B |
release/woocommerce-payments/assets/css/success.rtl.css |
173 B |
release/woocommerce-payments/dist/blocks-checkout.js |
61.1 kB |
release/woocommerce-payments/dist/bnpl-announcement-rtl.css |
528 B |
release/woocommerce-payments/dist/bnpl-announcement.css |
529 B |
release/woocommerce-payments/dist/bnpl-announcement.js |
20.8 kB |
release/woocommerce-payments/dist/cart-block.js |
16.1 kB |
release/woocommerce-payments/dist/cart.js |
5.67 kB |
release/woocommerce-payments/dist/checkout-rtl.css |
600 B |
release/woocommerce-payments/dist/checkout.css |
600 B |
release/woocommerce-payments/dist/checkout.js |
31.7 kB |
release/woocommerce-payments/dist/express-checkout-rtl.css |
235 B |
release/woocommerce-payments/dist/express-checkout.css |
235 B |
release/woocommerce-payments/dist/express-checkout.js |
13.9 kB |
release/woocommerce-payments/dist/index-rtl.css |
39.1 kB |
release/woocommerce-payments/dist/index.css |
39 kB |
release/woocommerce-payments/dist/index.js |
296 kB |
release/woocommerce-payments/dist/multi-currency-analytics.js |
1.08 kB |
release/woocommerce-payments/dist/multi-currency-rtl.css |
3.41 kB |
release/woocommerce-payments/dist/multi-currency-switcher-block.js |
60.5 kB |
release/woocommerce-payments/dist/multi-currency.css |
3.41 kB |
release/woocommerce-payments/dist/multi-currency.js |
55.5 kB |
release/woocommerce-payments/dist/order-rtl.css |
730 B |
release/woocommerce-payments/dist/order.css |
730 B |
release/woocommerce-payments/dist/order.js |
42.7 kB |
release/woocommerce-payments/dist/payment-gateways-rtl.css |
1.35 kB |
release/woocommerce-payments/dist/payment-gateways.css |
1.35 kB |
release/woocommerce-payments/dist/payment-gateways.js |
39.2 kB |
release/woocommerce-payments/dist/payment-request-rtl.css |
235 B |
release/woocommerce-payments/dist/payment-request.css |
235 B |
release/woocommerce-payments/dist/payment-request.js |
13.5 kB |
release/woocommerce-payments/dist/plugins-page-rtl.css |
386 B |
release/woocommerce-payments/dist/plugins-page.css |
386 B |
release/woocommerce-payments/dist/plugins-page.js |
20.1 kB |
release/woocommerce-payments/dist/product-details-rtl.css |
397 B |
release/woocommerce-payments/dist/product-details.css |
398 B |
release/woocommerce-payments/dist/product-details.js |
11.3 kB |
release/woocommerce-payments/dist/settings-rtl.css |
11.2 kB |
release/woocommerce-payments/dist/settings.css |
11.1 kB |
release/woocommerce-payments/dist/settings.js |
223 kB |
release/woocommerce-payments/dist/subscription-edit-page.js |
703 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css |
524 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal.css |
524 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal.js |
20.2 kB |
release/woocommerce-payments/dist/subscription-product-onboarding-toast.js |
730 B |
release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css |
120 B |
release/woocommerce-payments/dist/subscriptions-empty-state.css |
120 B |
release/woocommerce-payments/dist/subscriptions-empty-state.js |
19.3 kB |
release/woocommerce-payments/dist/tokenized-payment-request-rtl.css |
235 B |
release/woocommerce-payments/dist/tokenized-payment-request.css |
235 B |
release/woocommerce-payments/dist/tokenized-payment-request.js |
14.3 kB |
release/woocommerce-payments/dist/tos-rtl.css |
235 B |
release/woocommerce-payments/dist/tos.css |
235 B |
release/woocommerce-payments/dist/tos.js |
21.8 kB |
release/woocommerce-payments/dist/woopay-direct-checkout.js |
6.08 kB |
release/woocommerce-payments/dist/woopay-express-button-rtl.css |
235 B |
release/woocommerce-payments/dist/woopay-express-button.css |
235 B |
release/woocommerce-payments/dist/woopay-express-button.js |
23.9 kB |
release/woocommerce-payments/dist/woopay-rtl.css |
4.5 kB |
release/woocommerce-payments/dist/woopay.css |
4.47 kB |
release/woocommerce-payments/dist/woopay.js |
70.9 kB |
release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css |
625 B |
release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js |
814 B |
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js |
2.46 kB |
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js |
1.02 kB |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.css |
198 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.js |
20 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.rtl.css |
198 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.css |
625 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.js |
20 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.rtl.css |
626 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-users.js |
392 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js |
521 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js |
584 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.css |
215 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.js |
521 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.css |
721 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.js |
412 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-users.js |
520 B |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js |
159 B |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css |
2.36 kB |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js |
13.6 kB |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css |
2.36 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css |
1.04 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css |
294 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css |
408 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css |
3.59 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css |
301 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css |
746 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css |
574 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css |
414 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js |
543 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js |
9.4 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js |
6.78 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js |
3.84 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js |
545 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js |
2.52 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js |
22.2 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js |
11.7 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js |
1.29 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js |
507 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js |
358 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js |
428 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js |
1.38 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js |
782 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js |
1.09 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js |
1.26 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css |
391 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js |
3.04 kB |
nikkivias
approved these changes
Jul 26, 2024
bborman22
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
I ran through all the test instructions covering the matrix of the following settings:
- CTA: Icon, Buy, Donate, Book
- Size: Small, Medium, Large
- Browser: Chrome, Safari
- Page: Product, Cart, Cart Block Checkout, Checkout Block
I only spotted two visual issues both on the Checkout Block, but I also confirmed that #9124 fixes both issues!!
- When Donate CTA is used on Chrome, the button text is too tight.
- With any CTA on Safari the Apple Pay button overlaps the WooPay button.
Again just to be clear both issues are resolved by #9124 so no action needs to be taken on this PR, but want to note that makes #9124 a required PR for this release.
LGTM!
lovo-h
added a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Hector Lovo <hector.lovo@automattic.com> Co-authored-by: Hector Lovo <lovohh@gmail.com> Co-authored-by: Brian Borman <68524302+bborman22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8136
Changes proposed in this Pull Request
The changes in this PR ensure the WooPay button label's font sizes are more in line with the other PRB/ECE buttons:
18pxacross all breakpoints22pxacross all breakpoints26pxacross all breakpointsAdditionally, the WooPay button's design has been updated so that it matches better with the other PRB/ECE buttons.
Testing instructions
Test: Ensure WooPay font sizes display as intended
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge