Add survey modal on WooPayments deactivation #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +20.1 kB (+2%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@elizaan36, what do you think about developing a new CrowdSignal style theme? This would help reduce the spacing between paragraphs and headings, allowing us to fit the survey into the modal without requiring a scrollbar. |
|
hey @mordeth How do you create a new theme in Crowdsignal? |
If you scroll down on the theme selection screen, you'll find a button to create a new custom theme. If you prefer, I can create a new theme style with reduced spacings, and you can review it later. WDYT? |
Thanks @mordeth, I think it would help a lot if you were able to give that a try! I mocked it up quickly to see how we could adjust the spacing. Here I've reduced spacing between the selections, and the Additional comments. 
Also it would balance the form to have equal margins top and bottom (it needed some space above the WooPayments logo). Hopefully this can help remove the scrollbar. WDYT? |
oaratovskyi
approved these changes
May 20, 2024
There was a problem hiding this comment.
Tested, worked well with a fix we discussed in Slack p1716195847191189/1716192002.072229-slack-C03KTTK2YMA! Left a couple of code suggestions, the main is to add wp-components as a dependency to make it work. Pre-approving 🟢
Leaving the design approval to @elizaan36
elizaan36
approved these changes
May 20, 2024
|
@oaratovskyi Could you please review and test the updated approach again? The survey should always be displayed the first time of deactivation. After that, it should not be shown for the next 7 days, and then every 7 days after it has been successfully displayed. |
|
sure @mordeth ! I'll do it tomorrow |
elazzabi
requested changes
Jun 5, 2024
@elazzabi There is a known issue with the Please use the CLI command |
|
Hmmm weird, I still can't get it to work even with the CLI command ^ 🤔 |
elazzabi
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Ok tested this with a JN site:
- First, spinning up the JN site with this PR
- Deactivating the plugin, the modal shows
- For some reason, once the plugin is deactivated, it is completely removed (I double-checked with another random PR and the same thing happens in JN, probably something with Jetpack Beta or how JN websites work... See video next)
- Installed the plugin again
- Deactivating the plugin again, the modal doesn't show
All good ✅
Screen.Recording.2024-06-05.at.10.43.42.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1527
Changes proposed in this Pull Request
This PR aims to enhance user experience by implementing a feedback survey modal upon deactivation of the WooPayments plugin. Providing users with the opportunity to share their feedback upon deactivation will help us better understand their needs and preferences, ultimately leading to a more refined product.
Testing instructions
Case 1
Plugins.WooPaymentsplugin.Case 2
Plugins.wp option update wcpay_exit_survey_last_shown 2024-06-04T11:05:42.291ZWooPaymentsplugin.Case 3
Plugins.wp option update wcpay_exit_survey_last_shown 2024-05-01T11:05:42.291Z.WooPaymentsplugin.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge