-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add order id mismatch exception #8855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
force-pushed
the
add/new-process-payment-exception
branch
3 times, most recently
from
May 22, 2024 18:18
e1ff53d
to
b9811de
Compare
hsingyuc
changed the base branch from
add/new-process-payment-exception
to
develop
May 23, 2024 20:34
hsingyuc
force-pushed
the
add/order-id-mismatch-exception
branch
from
May 23, 2024 20:41
b702452
to
d9702fc
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
hsingyuc
requested review from
a team and
alefesouza
and removed request for
a team
May 24, 2024 17:39
alefesouza
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hsingyuc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR is an extension of the Pass previous Exception with Exception PR and creates an unique exception
Order_ID_Mismatch
when getting generic error message likeWe're not able to process this request. Please refresh the page and try again.
so it would be easier for us to identify where the error is coming from later on.Testing instructions
true
Oops, we couldn't complete the order and your card has been refunded. Please try again.
"previous": "WCPay\\Exceptions\\Order_ID_Mismatch_Exception"
. Example below:npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge