Validate route params before making request #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
marcinbot
requested changes
Jun 4, 2024
…/woocommerce-payments into update/route-param-validation
marcinbot
approved these changes
Jun 7, 2024
brucealdridge
added a commit
that referenced
this pull request
Jun 24, 2024
This reverts commit bbdbafb.
13 tasks
brucealdridge
added a commit
that referenced
this pull request
Jun 25, 2024
This reverts commit bbdbafb.
dmvrtx
pushed a commit
that referenced
this pull request
Jun 25, 2024
This PR reverts #8901 which introduced stricter REST route validation of unique object IDs. Restoring the validation of these URLs to the state in WooPayments 7.7.0. The original PR increased validation with stricter object ID's checking moving from `\w+` to `[A-Za-z0-9]+` regex. Charges and disputes also had specific prefixes required `(ch|py|pi)_` and `(dispute|dp)_`. After the release of WooPayments 7.8.0 reports came in that confirmed dispute objects can also have a prefix of `du_`. Due to the original PR, these disputes were unable to viewed or responded to. As per [Stripe docs](https://docs.stripe.com/upgrades#what-changes-does-stripe-consider-to-be-backwards-compatible), changing ID prefixes is considered backwards compatible: > Stripe considers the following changes to be backwards-compatible: > Changing the length or format of opaque strings, such as object IDs, error messages, and other human-readable strings. > This includes adding or removing fixed prefixes (such as ch_ on charge IDs).⚠️
dmvrtx
pushed a commit
that referenced
this pull request
Jun 25, 2024
This PR reverts #8901 which introduced stricter REST route validation of unique object IDs. Restoring the validation of these URLs to the state in WooPayments 7.7.0. The original PR increased validation with stricter object ID's checking moving from `\w+` to `[A-Za-z0-9]+` regex. Charges and disputes also had specific prefixes required `(ch|py|pi)_` and `(dispute|dp)_`. After the release of WooPayments 7.8.0 reports came in that confirmed dispute objects can also have a prefix of `du_`. Due to the original PR, these disputes were unable to viewed or responded to. As per [Stripe docs](https://docs.stripe.com/upgrades#what-changes-does-stripe-consider-to-be-backwards-compatible), changing ID prefixes is considered backwards compatible: > Stripe considers the following changes to be backwards-compatible: > Changing the length or format of opaque strings, such as object IDs, error messages, and other human-readable strings. > This includes adding or removing fixed prefixes (such as ch_ on charge IDs).⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woocommerce-payments-server/issues/1548
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge