chore: EPMs to always send shipping phone #8902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +31 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
Error message is displayed when a combination of this PR and phone number is marked as "required".
This PR ensures that we're always sending the shipping phone to the backend - regardless of whether it's required or not.
Stripe doesn't provide us with a different phone number, so we're just going to use the same phone number value used for billing.
I implemented/copied this solution for/to all the variations of the EPMs we currently have.
Discussed internally here: p1717173350842549-slack-CU6SYV31A
Testing instructions
Test the scenario without this patch, first
I also tested this with WC 8.9.1 for good measure.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge