Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECE not working without WooPay #8905

Merged
merged 6 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/as-fix-ece-with-woopay
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: add

Fix ECE not working without WooPay.
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ const ExpressCheckoutContainer = ( props ) => {
};

return (
<Elements stripe={ stripe } options={ options }>
<ExpressCheckoutComponent { ...props } />
</Elements>
<div style={ { minHeight: '50px' } }>
<Elements stripe={ stripe } options={ options }>
<ExpressCheckoutComponent { ...props } />
</Elements>
</div>
);
};

Expand Down
8 changes: 1 addition & 7 deletions client/express-checkout/blocks/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* global wcpayConfig, wcpayExpressCheckoutParams */

/**
* Internal dependencies
*/
Expand All @@ -26,11 +24,7 @@ const expressCheckoutElementPaymentMethod = ( api ) => ( {
return false;
}

if ( typeof wcpayConfig !== 'undefined' ) {
return wcpayConfig.isExpressCheckoutElementEnabled;
}

return false;
return true;
},
} );

Expand Down
Loading