Fix credit card input errors and checkout errors E2E tests #8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +23 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
frosso
approved these changes
Jun 5, 2024
| isPaymentInformationCompleteRef.current = event.complete; | ||
| const setHasLoadError = ( event ) => { | ||
| hasLoadErrorRef.current = true; | ||
| onLoadError( event ); |
There was a problem hiding this comment.
If the onLoadError is not provided, this call would throw an exception, because you can't call event on undefined.
What was the reason for removing the noop default assignment on L63?
There was a problem hiding this comment.
That was a mindless change 😬. Good catch! Fixed in e50bf25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The objective of this PR is two-fold:
shopper-checkout-failuresE2E tests.Changes proposed in this Pull Request
Testing instructions
Test 1: Ensure input-specific credit card errors are displayed again
Test 2: Ensure there's no regression with +1M value error
Please follow the instructions from #8793 and ensure the notice still appears for carts with over 1M in value.
Test 3: Ensure shopper-checkout-failures E2E test spec passes
No manual testing is required.
Ensure the E2E Tests - All workflow passes in this branch for the shopper checkout failures spec by looking for this log:
Note: Other test specs are still failing.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.