Enable WP_DEBUG to be able to get previous Exception class #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
requested review from
a team and
malithsen
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
malithsen
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Thanks @hsingyuc Looks good. I also tested that the previous is logged in WooPay with these changes when WP_DEBUG is set to false and everything tests as expected.
Left a couple of comments but I am good with merging this as-is.
hsingyuc
force-pushed
the
add/add-wc-return-previous-exceptions-filter
branch
from
3b2681b to
5b4a8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
We only get the
previous Exceptionclass whenWP_DEBUGis enabled; otherwise, theExceptionclass name will be exposed at frontend.Slack discussion: https://a8c.slack.com/archives/C8X6Q7XQU/p1717505760671199?thread_ts=1717144904.072499&cid=C8X6Q7XQU
WC changes: woocommerce/woocommerce@a96d5d7
Testing instructions
Update
WP_DEBUGmode totrueAdd an item to your cart by POSTing to
{YOUR_DOMAIN}/wp-json/wc/store/v1/cart/add-item{YOUR_DOMAIN}/wp-json/wc/store/v1/checkoutWP_DEBUGmode tofalsenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge