Fix duplicated enqueued scripts in shortcode checkout #8954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ricardo
requested review from
a team and
rafaelzaleski
and removed request for
a team
|
@rafaelzaleski This is not urgent as I'm planning to merge after the code freeze on Sunday so this gets properly tested in all testing rounds from GlobalStep. |
rafaelzaleski
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Code looks good!
✅ This PR fixes the repeated enqueue issue
✅ This PR fixes WooPay OTP modal does not render on the shortcode checkout if BNPL methods are available #8863
✅ Regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8863
Changes proposed in this Pull Request
Currently, when multiple WooPayments payment methods are available, certain scripts are being enqueued more than once in the shortcode checkout:
This is because
WC_Payments_Checkoutgets instantiated for every WC payment gateway, and therefore almost the samewp_enqueue_scriptshook gets called multiple times.This is a long standing issue that was introduced when the UPE payment methods were separated into different WooCommerce payment gateways.
This PR adds a simple check so
wcpay-upe-checkoutandwcpay-fraud-prevention-tokenscripts are not enqueued and localized twice.This results in:
wc_tokenization_form_paramsvariable is not repeated.wcpay_upe_configvariable is not repeated.wcpay_upe_config.icon,wcpay_upe_config.woopayMinimumSessionDataandwcpay_upe_config.isWooPayEnabled– The latter causing the issue seen in WooPay OTP modal does not render on the shortcode checkout if BNPL methods are available #8863.WooPay_Session::get_woopay_minimum_session_datais not called multiple times unnecessarily. 💪Testing instructions
Reproducing the issue
developbranch.var wcpay_upe_config.var wcpay_upe_config.Fixing WooPay OTP modal does not render on the shortcode checkout if BNPL methods are available #8863
Follow the steps to reproduce from #8863 and ensure the issue can no longer be reproduced in this branch.
Regression tests
Perform smoke tests in the following, both in blocks and shortcode checkout:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.