Fix WooPay Direct Checkout feature check #8979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
lovo-h
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Code changes look good and test well.
Test Instructions
- ✅ Regression test: Ensure direct checkout no longer depends on enabling first-party auth
- ✅ Regression test: direct checkout feature
- ✅ Test: Direct Checkout scripts are not enqueued if WooPay is disabled
- ✅ Test: Direct Checkout scripts are enqueued if WooPay is enabled
- ✅
npm run test:jsandnpm run test:php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
We're changing the Direct Checkout feature check so that it evaluates to
truewhen WooPay is enabled instead of eligible. That will prevent unnecessary HTTP requests that would be made even when the merchant explicitly disabled WooPay.Testing instructions
Regression test: Ensure direct checkout no longer depends on enabling first party auth
npm run wp option update _wcpay_feature_woopay_first_party_auth 0to disable first party auth.Regression test: direct checkout feature
Test: Direct Checkout scripts are not enqueued if WooPay is disabled
WCPAY_WOOPAY_DIRECT_CHECKOUTscript is NOT enqueued in the page source.Test: Direct Checkout scripts are enqueued if WooPay is enabled
WCPAY_WOOPAY_DIRECT_CHECKOUTscript is enqueued in the page source.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge