Fix: Hide payment methods with domestic transactions restrictions (Klarna, Affirm, Afterpay) when conditions are not met #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able countries for Klarna
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
danielmx-dev
commented
Jun 18, 2024
Comment on lines
+125
to
+138
| 'UK account with EUR store currency' => [ | ||
| 'account_country' => Country_Code::UNITED_KINGDOM, | ||
| 'site_currency' => Currency_Code::EURO, | ||
| 'expected_result' => [ | ||
| Country_Code::AUSTRIA, | ||
| Country_Code::BELGIUM, | ||
| Country_Code::FINLAND, | ||
| Country_Code::GERMANY, | ||
| Country_Code::IRELAND, | ||
| Country_Code::ITALY, | ||
| Country_Code::NETHERLANDS, | ||
| Country_Code::SPAIN, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Although this is a valid scenario, currently there is not way to manually test it due to the limitations described here #8718 (comment) Which should be addressed as part of a new issue.
danielmx-dev
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
approved these changes
Jun 20, 2024
danielmx-dev
deleted the
fix/8718-restrict-klarna-non-domestic-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8718
Changes proposed in this Pull Request
This PR performs a similar fix as the one performed here woocommerce/woocommerce-gateway-stripe#3108, the same PR description also applies here:
The only significant difference in this PR, is that we also perform a currency check for Klarna and EEA/UK/CH purchases in order to validate that the presentment currency matches the customer's country. This prevents, for example, showing Klarna when the customer country is Spain (ES) but the currency is set to GBP, since Spain's domestic currency is EUR (even if both currencies are technically supported).
Testing instructions
Scenarios
Use these provided scenarios along with the instructions to validate the expected result. Please note that this list of scenarios is not exhaustive, but should cover the most significant combinations.
Account Country
checkout
*Note: You can replace Belgium (BE) with any of the countries in this list (except Spain) to achieve the same results.
?currency=<Store Currency>npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge