Save selected date preset into session #8983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +46 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
added 2 commits
June 19, 2024 17:19
…tps://github.com/Automattic/woocommerce-payments into update/8972-save-payment-activity-preset-session
haszari
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Code looks safe & straightforward, no concerns.
This is what I tested:
- View
Payments > Overview - Select
Last 3 monthspreset, peruse the stats - Click a tile to view list of transactions
- Click back
- Widget shows
Last 3 months✅
- Widget shows
- Reload page
- Widget shows
Last 3 months✅
- Widget shows
So looking good.
I tried logging out and logging back in again, to see if it would revert back to default Last 7 days. However, my Last 3 months setting was used again! This seems minor, though maybe not what was intended.
@jessy-p do you know how/when the session storage clears out/resets? Do we need to do something to explicitly delete this on logout? What behaviour is desired here (i.e. when should it revert to default)?
Doh! I should have read the description more carefully! 🤦🏻
Close and re-open the tab, check that Payments Overview shows the default date range.
Retested this – closing tab reverts back to the default time period. ✅
So all good to merge IMO! 🚀
shendy-a8c
approved these changes
Jun 21, 2024
|
I didn’t review, just approving PR because it has been reviewed and there is no outstanding feedback to follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8972
Changes proposed in this Pull Request
Save the user selected preset into session, so that it persists within the session.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge
Not applicable