Add Pay for Order support in ECE #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +293 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
cesarcosta99
force-pushed
the
add/8869-pay-for-order-support-in-ece
branch
from
cc36642 to
62083f6
Compare
cesarcosta99
requested review from
a team and
lovo-h
and removed request for
a team
lovo-h
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Code changes are looking good and testing well.
I left a few nit comments, but there were two we may want to handle before merging:
- Unintentionally left behind comment.
- Duplicate code that we may be able to de-duplicate for easier maintenance. This one might be optional.
Testing Instructions
- 🟢 Regression test: Payment request buttons work as expected when ECE is disabled.
- 🟢 Regression test: Checkout with ECE still works in the standard flows.
- 🟢 Regression test: Regular checkout works when no express checkout payment method is active.
- 🟢 Test: Checkout with ECE in Pay for Order works with WooPay disabled.
- 🟢 Test: Checkout with ECE in Pay for Order works with WooPay enabled.
- 🟢
npm run test:js.
lovo-h
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Code changes look good and test well.
Testing Instructions
- 🟢 Regression test: Payment request buttons work as expected when ECE is disabled.
- 🟢 Regression test: Checkout with ECE still works in the standard flows.
- 🟢 Regression test: Regular checkout works when no express checkout payment method is active.
- 🟢 Test: Checkout with ECE in Pay for Order works with WooPay disabled.
- 🟢 Test: Checkout with ECE in Pay for Order works with WooPay enabled.
- 🟢
npm run test:jsandnpm run test:php.
Note: For the test Regression test: Payment request buttons work as expected when ECE is disabled, I was not able to get the PRBs to load due to the issue reported here:
- p1719971520784039-slack-CU6SYV31A
However, I got things to work as intended by checking out to the commit right before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8869.
Changes proposed in this Pull Request
This PR is getting the Express Checkout Elements (ECE) rendered in the Pay for Order flow and introducing the payment processing implementation for the same flow.
Testing instructions
Important
This has been tested using Google Pay since it is currently difficult to test Apple Pay due to Apple Pay's requirements for test cards.
Important
You must test these changes on a public facing URL using HTTPS. Use something like Jurassic Tube or ngrok to create a tunnel to your local environment.
Setup
Ensure ECE is disabled by setting the
_wcpay_feature_stripe_eceoption to0.Regression test: Payment request buttons work as expected when ECE is disabled
Regression test: Checkout with ECE still works in the standard flows
_wcpay_feature_stripe_eceoption to1.Regression test: Regular checkout works when no express checkout payment method is active
Test: Checkout with ECE in Pay for Order works with WooPay disabled
Test: Checkout with ECE in Pay for Order works with WooPay enabled
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge