fix: pricing decimal formatting for tokenized cart #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
changed the base branch from
develop
to
fix/tokenized-cart-decimals-price
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +26 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
timur27
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Looks good 👍 Left a few cosmetic non-blocking comments, and I also have one question: when using currencies with two decimal places (I tried with USD & Hungarian forint), no matter how many decimal points I set in the settings, Google Pay modal always displays the price with two decimal points. The price is correct so I don't think that this behavior is incorrect, but rather worth mentioning.
client/tokenized-payment-request/transformers/__tests__/wc-to-stripe.test.js
Outdated
Show resolved
Hide resolved
client/tokenized-payment-request/transformers/__tests__/wc-to-stripe.test.js
Outdated
Show resolved
Hide resolved
client/tokenized-payment-request/transformers/__tests__/wc-to-stripe.test.js
Outdated
Show resolved
Hide resolved
…stripe.test.js Co-authored-by: Timur Karimov <timur.karimow.95@gmail.com>
…stripe.test.js Co-authored-by: Timur Karimov <timur.karimow.95@gmail.com>
…stripe.test.js Co-authored-by: Timur Karimov <timur.karimow.95@gmail.com>
Yeah, it's up to GooglePay (or Stripe?) to decide whether decimals are displayed or not. With these changes, I'm just trying to ensure the correct price is sent over :) |
nagpai
pushed a commit
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Timur Karimov <timur.karimow.95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tokenized cart for #8277
Changes proposed in this Pull Request
The amount displayed for zero-decimal currencies is wrong when using the PRBs w/ tokenized cart.
This is because Stripe has a concept of "zero decimal currency". Usually, we pass the PRBs a value expressed in cents. But for zero-decimal-currencies (like the Japanese Yen), the amount should be in Yen (they don't have Yen-cents).
Fixing.
Before:
After:
Testing instructions
2to0(for example - you could also try1)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge