-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the Payment Activity Card for all merchants (remove feature flag _wcpay_feature_payment_overview_widget
)
#9012
Open
Jinksi
wants to merge
10
commits into
develop
Choose a base branch
from
update/remove-feature-flag-payment-overview-widget
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
924c8c5
Remove feature flag `_wcpay_feature_payment_overview_widget`
Jinksi 75608a6
Add changelog entry
Jinksi a8a6f0d
Fix Payments Overview screen tests
Jinksi 72cbf17
Add Payments Overview → Payment Activity Card integration test
Jinksi 09fa2e9
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi 1381532
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi cc2e1ac
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi 537a384
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi e467a8f
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi f9db95d
Merge branch 'develop' into update/remove-feature-flag-payment-overvi…
Jinksi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: add | ||
|
||
Enable the Payment Activity Card for all merchants, allowing merchants to easily view a snapshot and analysis of their payment activity from the Payments Overview screen. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,23 +15,16 @@ | |
* WC Payments Features class | ||
*/ | ||
class WC_Payments_Features { | ||
/** | ||
* If you need to remove or deprecate a flag: | ||
* - Please update the `Erase_Deprecated_Flags_And_Options` migration with: | ||
* - The next version of WooPayments. | ||
* - The flag to be deleted. | ||
*/ | ||
const WCPAY_SUBSCRIPTIONS_FLAG_NAME = '_wcpay_feature_subscriptions'; | ||
const STRIPE_BILLING_FLAG_NAME = '_wcpay_feature_stripe_billing'; | ||
const STRIPE_ECE_FLAG_NAME = '_wcpay_feature_stripe_ece'; | ||
const WOOPAY_EXPRESS_CHECKOUT_FLAG_NAME = '_wcpay_feature_woopay_express_checkout'; | ||
const WOOPAY_FIRST_PARTY_AUTH_FLAG_NAME = '_wcpay_feature_woopay_first_party_auth'; | ||
const WOOPAY_DIRECT_CHECKOUT_FLAG_NAME = '_wcpay_feature_woopay_direct_checkout'; | ||
const AUTH_AND_CAPTURE_FLAG_NAME = '_wcpay_feature_auth_and_capture'; | ||
const DISPUTE_ISSUER_EVIDENCE = '_wcpay_feature_dispute_issuer_evidence'; | ||
const TOKENIZED_CART_PRB_FLAG_NAME = '_wcpay_feature_tokenized_cart_prb'; | ||
const PAYMENT_OVERVIEW_WIDGET_FLAG_NAME = '_wcpay_feature_payment_overview_widget'; | ||
const WOOPAY_GLOBAL_THEME_SUPPORT_FLAG_NAME = '_wcpay_feature_woopay_global_theme_support'; | ||
const WCPAY_SUBSCRIPTIONS_FLAG_NAME = '_wcpay_feature_subscriptions'; | ||
const STRIPE_BILLING_FLAG_NAME = '_wcpay_feature_stripe_billing'; | ||
const STRIPE_ECE_FLAG_NAME = '_wcpay_feature_stripe_ece'; | ||
const WOOPAY_EXPRESS_CHECKOUT_FLAG_NAME = '_wcpay_feature_woopay_express_checkout'; | ||
const WOOPAY_FIRST_PARTY_AUTH_FLAG_NAME = '_wcpay_feature_woopay_first_party_auth'; | ||
const WOOPAY_DIRECT_CHECKOUT_FLAG_NAME = '_wcpay_feature_woopay_direct_checkout'; | ||
const AUTH_AND_CAPTURE_FLAG_NAME = '_wcpay_feature_auth_and_capture'; | ||
const DISPUTE_ISSUER_EVIDENCE = '_wcpay_feature_dispute_issuer_evidence'; | ||
const STREAMLINE_REFUNDS_FLAG_NAME = '_wcpay_feature_streamline_refunds'; | ||
const TOKENIZED_CART_PRB_FLAG_NAME = '_wcpay_feature_tokenized_cart_prb'; | ||
|
||
/** | ||
* Indicates whether card payments are enabled for this (Stripe) account. | ||
|
@@ -239,15 +232,6 @@ public static function is_woopay_first_party_auth_enabled() { | |
return '1' === get_option( self::WOOPAY_FIRST_PARTY_AUTH_FLAG_NAME, '1' ) && self::is_woopay_express_checkout_enabled(); | ||
} | ||
|
||
/** | ||
* Checks whether Payment Overview Widget is enabled. | ||
* | ||
* @return bool | ||
*/ | ||
public static function is_payment_overview_widget_ui_enabled(): bool { | ||
return '1' === get_option( self::PAYMENT_OVERVIEW_WIDGET_FLAG_NAME, '0' ); | ||
} | ||
|
||
/** | ||
* Checks whether WooPay Direct Checkout is enabled. | ||
* | ||
|
@@ -385,7 +369,7 @@ public static function to_array() { | |
'woopayExpressCheckout' => self::is_woopay_express_checkout_enabled(), | ||
'isAuthAndCaptureEnabled' => self::is_auth_and_capture_enabled(), | ||
'isDisputeIssuerEvidenceEnabled' => self::is_dispute_issuer_evidence_enabled(), | ||
'isPaymentOverviewWidgetEnabled' => self::is_payment_overview_widget_ui_enabled(), | ||
'isRefundControlsEnabled' => self::is_streamline_refunds_enabled(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
'isStripeEceEnabled' => self::is_stripe_ece_enabled(), | ||
] | ||
); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.