Fix transaction/document list advanced filter styling issue preventing dates to be input on mobile screens #9013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +812 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Code diff makes sense. Tested transactions, deposits, disputes, and documents list page on desktop and mobile and they look good.
Unrelated and I think it's a browser thing but dropdown shows up unexpectedly.
It happens to dropdown on product edit page as well, so it's just a quirk of the browser IMO.
|
Thanks @shendy-a8c 🙌
On iOS Safari, I see the select options closer to the input. 
I agree this may be browser-specific and a separate issue. Which browser are you seeing this bug in? |
Chrome on a Mac but made my viewport mobile via the dev tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8782
Changes proposed in this Pull Request
This PR fixes an issue with advanced filter styling that prevents merchants from interacting with date inputs on mobile screens.
The desired styling overrides for the advanced filter component are now applied consistently for all list screen instances of this (deposits, disputes, documents, transactions) from
/client/style.scss, rather than individually for each screen.Before
After
Testing instructions
Advanced filters→Date→Between.fromandtodates.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge