Add Docker support for local mu plugins #9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladolaru
added
focus: devops
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
|
@marcinbot I would appreciate your 👍 on if it is OK to introduce this. Maybe there are some risks I am not seeing. |
marcinbot
approved these changes
Jul 3, 2024
elazzabi
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good! And works as expected.
A few updates to the PR instructions:
Checkout the PR's branch and check that you have a docker/mu-plugins directory with just a .gitkeep file in it
This was actually true only after running npm run up, which is the second step.
require_once DIR . '/local-hacks/my-precious.php';
This should be require_once __DIR__ . '/local-helpers/my-precious.php';
Co-authored-by: Ahmed <ahmed.el.azzabi@automattic.com>
|
Thank you, Ahmed!
I messed up the commits. It is fixed now. The directory should be there without having to run
Good catch. I've updated the testing instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
We introduce a
docker/mu-pluginsdirectory that is mounted as thewp-content/mu-pluginsdirectory in your local client Docker container.This directory is a good place to stash your local development helper files to be loaded when/if needed, without versioning them since the directory is .gitignored. The documentation added provides more details and a recommended starting point.
Testing instructions
docker/mu-pluginsdirectory with just a.gitkeepfile in itnpm run updocker/mu-plugins/local-helpersdocker/mu-plugins/local-helpers/my-precious.phpand put in the following contents:docker/mu-plugins/0-local-helpers.phpand put in the following contents:0-local-helpers.phpplugin and ... something else :)docker/mu-plugins/0-local-helpers.phpand if you refresh the WP admin Plugins > Installed plugins > Must-Use page you should still see the0-local-helpers.phpplugin in the list, but no Gollum gif.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge