Register Independent ECE Payment Methods within the Blocks Implementation #9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
rafaelzaleski
changed the title
|
Size Change: +7.86 kB (+1%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
6 tasks
rafaelzaleski
requested review from
a team and
ricardo
and removed request for
a team
ricardo
requested changes
Jul 9, 2024
There was a problem hiding this comment.
PR looks really good. Nice work!
Tests went well:
- ✅ Apple Pay and Google Pay show up in separate ECE in the blocks cart page.
- ✅ Apple Pay and Google Pay show up in separate ECE in the blocks checkout page – however there's currently a limit of 2 buttons so I had to disable WooPay.
- ✅ I was able to checkout with both Apple Pay and Google Pay in the cart and checkout pages.
❌ I only see one issue with the preview being duplicated for Apple Pay, but this could be tackled in a separate issue perhaps.
client/express-checkout/blocks/components/express-checkout-component.js
Outdated
Show resolved
Hide resolved
ricardo
approved these changes
Jul 9, 2024
jessepearson
pushed a commit
that referenced
this pull request
Jul 11, 2024
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9045
Changes proposed in this Pull Request
This PR registers each Express Checkout Element (ECE) payment method individually in WC Blocks, allowing the Blocks API to manage these payment methods separately.
Testing instructions
Pre-requisites:
npm run wp option update _wcpay_feature_stripe_ece 1).Test the WC Blocks ECE implementation:
Repeat these steps for the Blocks Checkout page.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge