Added filter to update Level 3 data. #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
6 tasks
Add missing line item when slicing the array Co-authored-by: Samir Merchant <samir.merchant@automattic.com>
Version bump Co-authored-by: Samir Merchant <samir.merchant@automattic.com>
|
Thanks for the review, @FangedParakeet. 🙌 Responded. Edit: and updated the unit tests, as they previously created 2 + 499 = 501 items, and checked that the last item represented 301 items, while it needed to be 199 items + the last item representing 302 items to make up the whole 501. I updated the test helper |
FangedParakeet
approved these changes
Jul 19, 2024
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Samir Merchant <samir.merchant@automattic.com> Co-authored-by: Panos (Panagiotis Synetos) <2484390+PanosSynetos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Allow filtering level 3 data
This PR adds support to allow the use of WooCommerce gift cards to pay for order partially with full support for Level 3 data, with the rest being paid by another payment method provided by Woo Payments. This previously failed due to Level 3 data mismatch.
Description
Together with https://github.com/woocommerce/woocommerce-gift-cards/pull/822 serves as a POC to show how Gift Cards can be used as discounts with Woo Payments.
More background discussion available at p1718202231605999-slack-C3NCP7ZJ6
Initially, I only added the filter, but after working a bit more on the change in Gift Cards, it seems to me it's better if the payment gateway handles the bundling of line items after filtering for the following reasons:
On the other hand, it provides slightly less flexibility to the extension, but that would be an illusion of flexibility anyway, since the ability to send an invalid request to Stripe is worthless.
A similar chance is being done also in Stripe: woocommerce/woocommerce-gateway-stripe#3286
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge