Allow the purchase of physical subscriptions using ECE if no shipping options are defined #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovo-h
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
LGTM
Do you think we should also add the tests from #8024? Or will they be added later?
Testing Instructions
- 🟢 In the
developbranch, notice the error "The following problems were found: The payment request button is not - supported..." or something like that. - 🟢 In the
9106-ece-checkout-fails-for-physical-subscription-product-if-no-shipping-methods-are-configuredbranch, checkout should proceed without issues. - 🟢
npm run test:php.
includes/express-checkout/class-wc-payments-express-checkout-button-handler.php
Outdated
Show resolved
Hide resolved
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
I'll add the same tests 👍 |
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
…cription-product-if-no-shipping-methods-are-configured
asumaran
deleted the
9106-ece-checkout-fails-for-physical-subscription-product-if-no-shipping-methods-are-configured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9106
Changes proposed in this Pull Request
Applies the same changes from #8024 to fix the issue preventing subscription purchases when the store has no defined shipping options.
Testing instructions
developbranch9106-ece-checkout-fails-for-physical-subscription-product-if-no-shipping-methods-are-configurednpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge