Use payment_method_domains endpoint for domain registration.
#9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
rafaelzaleski
changed the title
payment_method_domains endpoint for domain registration.payment_method_domains endpoint for domain registration.
asumaran
reviewed
Jul 22, 2024
rafaelzaleski
requested review from
a team and
reykjalin
and removed request for
a team
reykjalin
requested changes
Jul 24, 2024
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Kristófer Reykjalín <13835680+reykjalin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9098
Changes proposed in this Pull Request
Use the
payment_method_domainsendpoint for domain registration, a requirement for processing Apple Pay payments in Express Checkout Elements (ECE).Testing instructions
Pre-requisites:
add/domain-registration-controlleron the server.On the
developbranch:npm run build:clientOn the
add/9098-domain-registration-endpoint-updatebranch:Test that it's possible to process Apple Pay payments in the new domain:
npm run build:clientdevelopbranch but ensure the Apple Pay button is visible.Check the logs for the
payment_method_domainsendpoint request:/wp-admin/admin.php?page=wc-status&tab=logs.payment_method_domains.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge