Support tokenized cart PRBs on blocks cart and checkout #9150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
FangedParakeet
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +4.48 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
FangedParakeet
requested changes
Jul 24, 2024
There was a problem hiding this comment.
For the most part, this worked as expected and looks pretty neat and tidy. 🙌
There is quite a lot of duplicated code inside event-handlers.js, which is unfortunate, but unfortunately I can't really think of a better way to recommend improving this without performing a considerable refactor of the entire implementation...which I would not recommend. 😅
I think that's fine for now, but I've left a few little queries, comments, and suggestions for your perusal nonetheless. Let me know your thoughts and hopefully there won't be anything that requires too much additional work to amend. 🙏
|
@FangedParakeet I think I've taken care of all comments. Let me know if see anything else out of place. |
FangedParakeet
requested changes
Jul 26, 2024
There was a problem hiding this comment.
I tested this out purchasing regular, variable, virtual, and subscription products and all succeeded as expected. 🎉
However, when the checkout/payment processing failed for some reason, I'm not sure that we are handling this correctly and the modal hangs for some time before failing with an unknown error. I think I've mentioned in a separate comment where I believe this can be resolved. Can you just review some of the error handling with this implementation please?
Once that's all set, I think this one should be good to go. 💪
FangedParakeet
approved these changes
Jul 30, 2024
FangedParakeet
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8527
Changes proposed in this Pull Request
This adds tokenized cart PRBs to the cart and checkout blocks. The goal is implement the PRB component on the blocks cart and checkout pages, removing any reliance on the older implementation.
Testing instructions
npm run wp option update _wcpay_feature_stripe_ece 0. To verify it's disabled you can check the WooPayments Express Checkout settings for a border radius option. Border radius only appears for the ECE buttons.Unknown.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge