Add button rules to appearance #9164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +569 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
hsingyuc
force-pushed
the
add/get-button-styles-by-selectors
branch
from
f4314e9 to
3f5bdc9
Compare
hsingyuc
changed the base branch from
develop
to
add/get-heading-color-by-selectors
hsingyuc
force-pushed
the
add/get-heading-color-by-selectors
branch
from
36df144 to
338bdc9
Compare
hsingyuc
changed the base branch from
add/get-heading-color-by-selectors
to
develop
hsingyuc
force-pushed
the
add/get-button-styles-by-selectors
branch
from
bca326f to
96c58fa
Compare
hsingyuc
force-pushed
the
add/get-button-styles-by-selectors
branch
from
96c58fa to
01360e1
Compare
leonardola
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woopay/issues/2812
Changes proposed in this Pull Request
This PR adds button rules to appearance to allow us to get button styles from checkout, cart and product pages.
EPIC https://github.com/Automattic/woopay/issues/2781
SPIKE here
PT here
Testing instructions
Test 1 ( The latest WooPayments version ):
getAppearanceon the merchant siteget_woopay_sessionrequest and findappearance[rules][.Button]Test 2 ( An older WooPayments version ):
getAppearanceon the merchant site for regression testnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge