Ensure 'wcSettings' Exists Before Checking for 'wcSettings.wcBlocksConfig' #9174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +30 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
bborman22
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
I was able to test this locally and on staging. To "break" the flow and cause an error message I just disabled the dev token secret being set in both environments. I then tested this in Cart, Cart Block, Checkout and Checkout Block. When the token was not set I properly saw an error message with this PR. When the token was set, I properly got redirected to WooPay.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes n/a
Changes proposed in this Pull Request
The changes in this PR ensure that the
wcSettingsglobal var exists before attempting to check forwcSettings.wcBlocksConfig.Testing instructions
Tip
These tests should be executed in the staging site.
Prerequisites
DEV_BLOG_TOKEN_SECRETdoes not match.Test: Ensure error message is displayed when
Buy with WooPayfails when in classic cart[woocommerce_cart]shortcode.Buy with WooPaybutton.Something went wrong. Please try again.Test: Ensure error message is displayed when
Buy with WooPayfails when in blocks cartcartwc-block.Buy with WooPaybutton.Something went wrong. Please try again.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge