Match the Node version in nvm with the minimum version in package.json #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
I had this problem the other day. Was thinking to create a PR with exactly the same change (my locally installed node was also 20.11) but decided not to because the readme clearly states to run |
|
@shendy-a8c Interesting. Thanks for highlighting this tidbit. I always start with |
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
#9190) Co-authored-by: Shendy <73803630+shendy-a8c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Node version in our plugin was recently upgraded from 16 to 20 in #9121. nvm was configured to use any v20 release. This is out of sync with the minimum version specified in
package.json- 20.11 - which may cause issues for someone with 20 < v < 20.11 installed. This PR brings the nvm version in sync with the one in package.json.Testing instructions
Without this change:
nvm use. This will pick up your local v20 installation.npm install. It will fail saying you do not need the minimum node version.With this change:
nvm use. You will be prompted to install a newer node version. Go ahead with it.npm installwill succeed.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge