-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Outdated Express Checkout Settings Notification #9207
Merged
lovo-h
merged 4 commits into
develop
from
update/9193-outdated-express-checkout-notification
Aug 5, 2024
Merged
Update Outdated Express Checkout Settings Notification #9207
lovo-h
merged 4 commits into
develop
from
update/9193-outdated-express-checkout-notification
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovo-h
requested review from
a team and
cesarcosta99
and removed request for
a team
August 2, 2024 15:15
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: -71 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
cesarcosta99
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and test well!
- Confirm Issue: Outdated Notification Exists In Express Checkout Settings ✅
- Confirm Fix: Updated Notification Exists In Express Checkout Settings ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9193
Changes proposed in this Pull Request
The changes in this PR update a notification in Express Checkout Settings from the
Notification
component to theInlineNotification
component. These changes were applied to match the latest designs, as detailed in #9193. Since this is a minor change, tests were omitted.Testing instructions
Confirm Issue: Outdated Notification Exists In Express Checkout Settings
develop
branch.Confirm Fix: Updated Notification Exists In Express Checkout Settings
update/9193-outdated-express-checkout-notification
branch.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge