Added better error message when mandate is wrong. #9231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
zmaglica
deleted the
fix/3075-add-better-error-message-when-mandate-is-wrong
branch
There was a problem hiding this comment.
Would be helpful to have a link to these error codes and store them as constant above IMO. @zmaglica
| @@ -775,6 +775,8 @@ private function get_failure_message_from_error( $error ): string { | |||
| return __( 'Microdeposit transfers failed. Please check the account, institution and transit numbers.', 'woocommerce-payments' ); | |||
| case 'payment_method_microdeposit_verification_attempts_exceeded': | |||
| return __( 'You have exceeded the number of allowed verification attempts.', 'woocommerce-payments' ); | |||
| case 'payment_intent_mandate_invalid': | |||
There was a problem hiding this comment.
Can we save these error codes as some constants above?
There was a problem hiding this comment.
We can. This is a great idea. Since this PR is already merged, I can address that in another PR or open an issue for that.
rafaelzaleski
pushed a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3075
Changes proposed in this Pull Request
This PR captures the
payment_intent_mandate_invaliderror code and displays a clearer error message to the end user.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge