Add connect.js library and embedded onboarding integration #9251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +3.97 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
dmallory42
changed the title
oaratovskyi
reviewed
Aug 20, 2024
…ssion is present)
|
@dmallory42 I've added jest unit test for the embedded component 6120c1c and checked that the submit button works fine on mobile! it was the simulator issue, look how it works on the real phone |
Co-authored-by: oaratovskyi <oleksandr.aratovskyi@automattic.com> Co-authored-by: Daniel Mallory <daniel.mallory@automattic.com> Co-authored-by: Vlad Olaru <vlad@pixelgrade.com>
oaratovskyi
approved these changes
Sep 6, 2024
Co-authored-by: oaratovskyi <oleksandr.aratovskyi@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9222, #9224, #9223, https://github.com/Automattic/woocommerce-payments-server/issues/6189
Changes proposed in this Pull Request
@stripe/connect-js,@stripe/react-connect-js)GET payments/onboarding/sessionandPOST payments/onboarding/finaliseto our clientTesting instructions
Before testing
npm installto install the Stripe libraries.npm run watchBefore each test (prerequisites)
localhost:8087and either marking the current account as deleted in thewcpay_accountstable, or updating theaccount_typevalue to be something other thanwcpay(e.g.wcpay+testing).Happy path
Progressive onboarding
United Statesas the countryOnboarding is left
Regression: check test drive KYC still work
Localisation
Tracking
wcadmin_wcpay_onboarding_flow_started- upon redirect to the MOXwcadmin_wcpay_onboarding_flow_step_completed- after completion of a step in the MOXwcadmin_wcpay_onboarding_flow_redirected- after loading the embedded component (note that the name of this event is slightly inaccurate to maintain backwards compatibility)wcadmin_wcpay_stripe_connected- after completion of the embedded onboarding.TODO
Implementation
onboarding/redirect@dmallory42Tests/other
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge