chore: rename BNPL payment methods description #9260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
requested review from
a team and
FangedParakeet
and removed request for
a team
|
Size Change: -211 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
This was referenced Aug 15, 2024
rafaelzaleski
pushed a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #8248
Changes proposed in this Pull Request
The requirements for #8248 are:
Creating a separate section means also making the
client/payment-methods/index.jsmore reusable.This comes with a hole bunch of changes, that might make it harder to review the PR.
So I decided to split the PR in multiple parts - to reduce the number of files to review. Hopefully this makes it easier.
The PR for bullet point number 2 will come shortly and will be based off of these changes.
This PR takes care of the first bullet point - removing the currency from BNPL methods & adjusting their description.
Testing instructions
Before:
After:
These changes also affect the onboarding flow, which can be found at https://wcpay.test/wp-admin/admin.php?page=wc-admin&path=%2Fpayments%2Fadditional-payment-methods
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge