chore: delete old feature flags from DB #9263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
frosso
commented
Aug 14, 2024
| @@ -33,7 +33,6 @@ declare const global: { | |||
| }; | |||
| featureFlags: { | |||
| isAuthAndCaptureEnabled: boolean; | |||
| isRefundControlsEnabled: boolean; | |||
There was a problem hiding this comment.
This flag was only used in tests - likely missed during a cleanup task.
| @@ -386,7 +367,6 @@ public static function to_array() { | |||
| 'woopayExpressCheckout' => self::is_woopay_express_checkout_enabled(), | |||
| 'isAuthAndCaptureEnabled' => self::is_auth_and_capture_enabled(), | |||
| 'isDisputeIssuerEvidenceEnabled' => self::is_dispute_issuer_evidence_enabled(), | |||
| 'isRefundControlsEnabled' => self::is_streamline_refunds_enabled(), | |||
There was a problem hiding this comment.
This flag was only used in tests - likely missed during a cleanup task.
Comment on lines
-55
to
-57
| public static function is_streamline_refunds_enabled(): bool { | ||
| return '1' === get_option( self::STREAMLINE_REFUNDS_FLAG_NAME, '0' ); | ||
| } |
There was a problem hiding this comment.
This method was only used in tests - likely missed during a cleanup task.
Comment on lines
-196
to
-198
| public static function is_subscription_migration_enabled() { | ||
| return '1' === get_option( '_wcpay_feature_allow_subscription_migrations', '0' ); | ||
| } |
There was a problem hiding this comment.
This method was not used anywhere in the codebase.
| @@ -54,8 +54,6 @@ function () { | |||
| } | |||
| ); | |||
|
|
|||
| update_option( '_wcpay_feature_allow_subscription_migrations', '1' ); | |||
There was a problem hiding this comment.
This flag was likely a leftover from a cleanup task
| @@ -37,16 +37,6 @@ public function set_up() { | |||
|
|
|||
| $this->order_service = new WC_Payments_Order_Service( $this->createMock( WC_Payments_API_Client::class ) ); | |||
| $this->order = WC_Helper_Order::create_order(); | |||
|
|
|||
| // Turn on fraud settings. | |||
| update_option( 'wcpay_fraud_protection_settings_active', '1' ); | |||
There was a problem hiding this comment.
This flag was not checked anywhere in the codebase, just in tests. Likely a leftover from a cleanup task.
| @@ -175,7 +175,6 @@ public function test_add_token_to_user_for_sepa() { | |||
| * Test add SEPA token to user with deferred intent creation UPE. | |||
| */ | |||
| public function test_add_token_to_user_for_sepa_deferred_intent_creation_upe() { | |||
| $this->mock_cache->method( 'get' )->willReturn( [ 'is_deferred_intent_creation_upe_enabled' => true ] ); | |||
There was a problem hiding this comment.
This flag was not checked anywhere in the codebase - likely a leftover from a cleanup task.
frosso
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
requested changes
Aug 14, 2024
includes/migrations/class-erase-deprecated-flags-and-options.php
Outdated
Show resolved
Hide resolved
gpressutto5
approved these changes
Aug 15, 2024
rafaelzaleski
pushed a commit
that referenced
this pull request
Aug 27, 2024
Co-authored-by: Guilherme Pressutto <gpressutto5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
I created a migration to delete old feature flags from the DB.
I am creating it because it looks like they might have never been cleaned.
Some of the feature flags might have been internal/developer facing, but others might have been customer-facing (like the UPE ones).
Cleaning them all up.
To gather this list, I went through the history of the
includes/class-wc-payments-features.phpand all its changes.Testing instructions
I added som tests for the migration.
8.1.0: https://github.com/Automattic/woocommerce-payments/blob/develop/woocommerce-payments.php#L14-L148.1.0_wcpay_feature_client_secret_encryptionoption no longer existsnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge