fix: translatable strings around currencies list #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -8 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
frosso
requested review from
a team and
danielmx-dev
and removed request for
a team
danielmx-dev
approved these changes
Aug 14, 2024
This was referenced Aug 15, 2024
rafaelzaleski
pushed a commit
that referenced
this pull request
Aug 27, 2024
Co-authored-by: Daniel Guerra <15204776+danielmx-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
I noticed some translation string issues when looking at the
BuildMissingCurrenciesTooltipMessageandListToCommaSeparatedSentencePartConverterfunctions inclient/components/currency-information-for-methods/index.js:currencyandcurrenciesstrings might not be directly translatable into the whole sentence. It's better to put the whole sentence for translators to translate (so that they can get a better context)ListToCommaSeparatedSentencePartConverterdoesn't provide a placeholder for the strings to be translated. Theandcould be taken without context, without considering that some languages might not use theandto join list of items, but they might use a,commajoinWithConjunctionutility in the codebase, but it's not used anywhere (besides tests). And it doesn't allow for Oxford commasBuildMissingCurrenciesTooltipMessageis used inside thecomponents/currency-information-for-methodsfile, but it's also imported directly by other componentsSo, I made the following changes:
ListToCommaSeparatedSentencePartConverterto a global scopeclient/utils/format-list-of-items.tsand renamed to something that is closer to wc_format_list_of_itemsBuildMissingCurrenciesTooltipMessagetogetMissingCurrenciesTooltipMessageand moved it to a separate utility file in themulti-currencysub-directoryjoinWithConjunctionin favor offormatListOfItemsCurrencyInformationForMethodsfromclient/components/(a global directory, made for reuse) toclient/additional-methods-setup/upe-preview-methods-selector/, since that's the only place it's usedTesting instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge