Support merchant site styles for WooPay when initializing through classic checkout #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malithsen
requested review from
a team and
alefesouza
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +393 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
alefesouza
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Code looks good and works as expected, thanks!
Tested:
✅ Using storefront theme with classic/shortcode checkout:
- Customized background color to a color different from the payment method section.
- Accessed WooPay with global theme support enabled
- WooPay background matched the merchant background.
Did the same steps with blocks checkout while on Storefront theme, also Tsubaki theme with classic and blocks checkout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woopay/issues/2835
Changes proposed in this Pull Request
Introduce custom selectors, so that WooPay prioritizes background styles from the customer details section instead of the payment form. This is because the payment form on classic checkout has different background colors which differs from the rest of the page.
Before
After
Testing instructions
WooPay global theme supportfeature flagnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge