-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Fix Payments > Settings test mode disable with test drive account #9319
Hot Fix Payments > Settings test mode disable with test drive account #9319
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +117 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, thanks for taking care of it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works well
Fixes #9296
Changes proposed in this Pull Request
Fix Payments > Settings test mode disable with test drive account
Testing instructions
Note from @dmallory42: for testing this PR, I recommend launching a new JN site using https://jurassic.ninja/ and manually uploading a build of this release (rather than using the Jetpack Live Branches feature). The reason for this is that the live branches includes Dev Tools, and sets the environment of the site to development, which can affect the behaviour and mask possible issues.
npm run build:release
command.Settings
page to enable live mode. Go through the onboarding again, ensure that it is not in test/sandbox mode (there should be notest
label on the Stripe KYC.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge