Fix BNPL payment method messaging loading state #9355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcosta99
requested review from
a team and
rafaelzaleski
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +235 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested changes
Aug 30, 2024
@rafaelzaleski, good call. I initially had thought about conditionally call We can achieve a good UI flow by hiding the container via CSS and I did that in db76836. It's a low-risk approach and it keeps the UI looking good. I opted for hiding the message container by default in the product pages (instead of the opposite) as the majority of products should have an amount higher than the minimum, being those an exception. Update: |
rafaelzaleski
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
@cesarcosta99, I tested a product below the minimum amount and another above it, and the UI looks good in both scenarios now. The blank space is gone—thanks for the changes!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9244.
Changes proposed in this Pull Request
This fixes the BNPL payment method messaging loading state. Previously, the skeleton was being displayed even if the product amount was lower than the minimum.
I needed to make the frontend aware of the minimum value so it has a value to compare to. Stripe doesn't provide a way to retrieve that information from their API, so I needed to build up a hardcoded list - sourced this idea from the Stripe extension [ref]. I pulled the values for this list from the Stripe docs.
Testing instructions
Setup
npm run build:client.Test: Ensure the payment method messaging skeleton works as expected
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge