Refactor loadStripe for Express Checkouts
#9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +65 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
asumaran
requested review from
a team and
cesarcosta99
and removed request for
a team
asumaran
requested review from
a team and
ricardo
and removed request for
cesarcosta99 and
a team
ricardo
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9685
This refactor originated from a comment (pcrvl0-1sv-p2#comment-743) on a P2 I published. It doesn’t introduce any new functionality. The changes are solely intended to prevent reintroducing the same bug (pcrvl0-1sv-p2) that #9523 fixed it.
Changes proposed in this Pull Request
Since loadStripe was introduced for Express Checkouts, the
forceAccountRequestparameter is unnecessary, as it should always use the merchant’s connected account with Stripe elements.Therefore, the
forceAccountRequestparameter is being removed, and the function renamed to clearly indicate it’s for Express Checkouts.All instances of
loadStripehas been updated to use the newloadStripeForExpressCheckoutTesting instructions
Tip
To thoroughly test these changes, I created a plugin .zip file using
npm run build:releaseand applied it to a fresh Jurassic Ninja site. This ensures the domain hadn’t been previously registered.Note
You need to use Ngrok or Jurassic Tube to test Apple Pay.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge