Add new tracking events and update Stripe connect library #9607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +215 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
vladolaru
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thank you for working on this, @dmallory42! The code changes LGTM and the Tracks events are fired accordingly. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9608
Changes proposed in this Pull Request
onStepChangeeventwcpay_onboarding_flow_embedded_step_changewcpay_onboarding_flow_redirectedwhich was lost in the change from external KYC to embedded KYC.Testing instructions
To test, you can either use the Tracks Vigilante extension (locally), or test using a Jurassic Ninja site and wait for the events to show up in Tracks Live View.
wcpay_onboarding_flow_redirected, which should happen when the embedded KYC page loads. You will also seewcpay_onboarding_flow_embedded_step_changeevents which occur when changing step on the embdedded KYC. They will have astepparameter which should contain a string indicating the current step on the KYC.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge