Record a tracks event when a merchant is redirected to a Stripe Capital loan offer #9652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Code change looks simple but I'm curious how the track event will be fired if right after it's recorded locally in memory, we are doing a redirect.
After some searches (and while waiting for my event to show up on Tracks MC page), I found this comment.
Anyway, since I can see the event from my blog after opening /wp-admin/admin.php?wcpay-loan-offer on the Tracks MC page. I guess it works. I don't need to know the details on how =)
changelog/fix-9651-record-tracks-event-capital-view-offer-redirect
Outdated
Show resolved
Hide resolved
Co-authored-by: Shendy <73803630+shendy-a8c@users.noreply.github.com>
Jinksi
deleted the
fix/9651-record-tracks-event-capital-view-offer-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9651
Changes proposed in this Pull Request
This PR adds a new tracks event
wcadmin_wcpay_capital_view_offer_redirectwhen a merchant is redirected to the Stripe Capital offer page, after clicking the View Offer/Details link in the offer email.Adding this event helps us to track how well Stripe Capital flows work (converts to loans) and if merchants are dropping off anywhere in the flow.
Testing instructions
/wp-admin/admin.php?wcpay-loan-offerwcadmin_wcpay_capital_view_offer_redirectand wait ~10mins – ensure your account shows up in this listnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge
Important
Don't forget post-merge tasks!
wcadmin_wcpay_capital_view_offer_redirecttracks event