Hide duplicate payment method warnings when Stripe gateway is disabled #9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
gpressutto5
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
gpressutto5
approved these changes
Nov 4, 2024
mdmoore
deleted the
fix/9271-hide-stripe-duplicates-warning-when-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9271
When another payment gateway enables a payment method that is already enabled in WooPayments, we display a warning.
As mentioned in #9271, when WooCommerce Stripe Gateway has PRBs enabled, yet the gateway is disabled, the duplicate payment method warning is still displayed. It shouldn't be, since PRBs from WooCommerce Stripe Gateway are not displayed when the gateway is disabled.
Changes proposed in this Pull Request
The issue is caused by these WooCommerce Stripe Gateway specific checks. After discussing with @timur27, these checks which skip checking if WooCommerce Stripe Gateway is enabled aren't needed. We can remove them and rely on the
'yes' === $gateway->enabledto ensure we're not displaying duplicate payment method notices for disabled gateways.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge