Fix multi-currency autoload issue when plugin gets updated #9681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
ricardo
force-pushed
the
fix/9676-multi-currency-autoload
branch
from
b670b85 to
2998a04
Compare
3 tasks
lovo-h
requested changes
Nov 6, 2024
Co-authored-by: Hector Lovo <hector.lovo@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9676
Changes proposed in this Pull Request
This issue happens because of the caveat explained in this comment:
woocommerce_get_settings_pageshook is called and the callback function fails to resolveSettings.For this reason and to avoid other potential risks, we're moving the multi-currency PHP source files back to their original paths.
This is an intermediary step until we rename the module's namespace and decouple it further from the gateway.
We are also adding a
did_action( 'upgrader_process_complete' )to prevent the same issue from happening in the future.Testing instructions
Test: Reproduce the issue and validate fix
Note: Remember to install the Query Monitor plugin to be able to see the error on JN.
Noteii: Remember to remove WooPayments and reinstall it from WPORG before repeating the test.
Follow instructions in #9676.
Run
npm run build:releaseand upload the contents from/release/woocommerce-paymentsfromdevelopand from this branch to reproduce and later to ensure the issue is fixed.Test: Ensure the issue won't repeat in future upgrades
To ensure the same error won't happen in future releases, we should simulate an autoloaded path change by changing the current plugin and uploading a build from
develop:npm run build:releaseand upload a zip from/release/woocommerce-payments.develop, run thebuild:releasescript and upload a zip on top of the previous one.did_action( 'upgrader_process_complete' )from this branch.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge