update: show LPM icon on order success page #9684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -1 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
frosso
commented
Nov 7, 2024
| } | ||
|
|
||
| .wc-payment-gateway-method-logo-wrapper.wc-payment-bnpl-logo img { | ||
| max-height: 30px; |
There was a problem hiding this comment.
Previously, there was a padding-top: 4px style, which was being subtracted from these 30px.
Now, the container itself has a 4px top padding (instead of the image). So I needed to subtract 4 from the original 30 in order to keep the image the same height.
The 4px top padding was cutting off some of the images like so (notice the top rounded corners):
There was a problem hiding this comment.
Ah, yeah, this is better. Thanks!
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
approved these changes
Nov 7, 2024
| } | ||
|
|
||
| .wc-payment-gateway-method-logo-wrapper.wc-payment-bnpl-logo img { | ||
| max-height: 30px; |
There was a problem hiding this comment.
Ah, yeah, this is better. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9682
Changes proposed in this Pull Request
Adding support for LPMs on "order success" pages.
Google Pay/Apple Pay/Link/Cards remain unaffected.
Here are some screenshots for proof:
Details
I also ensured to run the full suite of e2e tests: https://github.com/Automattic/woocommerce-payments/actions/runs/11722674600
Testing instructions
01-301 Warszawa Poland1010 Vienna Austrianpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge